Conversation
Sarah5567
reviewed
Dec 1, 2025
| const double MSE_THRESH = 20.0; | ||
| const double SSIM_THRESH = 0.998; | ||
| const double FLOW_THRESH = 0.5; | ||
| const double OPTICAL_FLOW_ACTIVE_THRESH = 0.5; |
Collaborator
There was a problem hiding this comment.
Great that you wrote them as constants, but please remove the initialization from the constructor or use these constants as the initial values there.
r83575
force-pushed
the
fix-threshold-values
branch
from
7999625 to
05e3701
Compare
lyuzinmaxim
approved these changes
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I checked the 4 videos for my PR - Align C++ frame skipping probe logic with Python implementation #168.
And I notice that the thresholds in the GPU version are not tuned well,
When they were tuned it's was on 4 colorful videos and probably this Is the reason.
This PR fixes this issue.